Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle breaking changes in frontend for "workspaces by provider" endpoint #375

Closed

Conversation

alex-mcgovern
Copy link
Collaborator

In stacklok/codegate#1233 I made a breaking change — GET /api/v1/workspaces/:provider_id was already in use for listing providers in use by a workspace, but now will return a full workspace by name. (GET /api/v1/workspaces/:provider_id).

The old functionality can be achieved with GET /api/v1/workspaces?provider_id={ID} now instead — this PR wires that up for the frontend.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13694811223

Details

  • 23 of 62 (37.1%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.4%) to 68.5%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/providers/hooks/use-confirm-delete-provider.tsx 0 1 0.0%
src/api/generated/sdk.gen.ts 7 14 50.0%
src/api/generated/@tanstack/react-query.gen.ts 16 47 34.04%
Files with Coverage Reduction New Missed Lines %
src/features/providers/hooks/use-confirm-delete-provider.tsx 1 0.0%
Totals Coverage Status
Change from base Build 13678205283: -1.4%
Covered Lines: 898
Relevant Lines: 1246

💛 - Coveralls

@alex-mcgovern
Copy link
Collaborator Author

Superseded by #379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants