Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shareable workspaces MVP (frontend) #379

Merged
merged 12 commits into from
Mar 17, 2025

Conversation

alex-mcgovern
Copy link
Collaborator

@alex-mcgovern alex-mcgovern commented Mar 7, 2025

  • Handles breaking changes introduced in the API to enable shareable workspaces
  • Adds a "download" / "upload" functionality to workspaces in the dashboard

@alex-mcgovern alex-mcgovern changed the title feat: shareable workspaces MVP feat: shareable workspaces MVP (frontend) Mar 7, 2025
@coveralls
Copy link
Collaborator

coveralls commented Mar 7, 2025

Pull Request Test Coverage Report for Build 13897242479

Details

  • 36 of 72 (50.0%) changed or added relevant lines in 14 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 66.303%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/providers/components/table-providers.tsx 0 1 0.0%
src/features/providers/hooks/use-confirm-delete-provider.tsx 0 1 0.0%
src/features/workspace/components/workspace-muxing-model.tsx 4 5 80.0%
src/features/workspace/lib/mux-model-serde.ts 4 5 80.0%
src/mocks/msw/handlers.ts 1 2 50.0%
src/features/providers/hooks/use-query-workspaces-by-provider.ts 0 2 0.0%
src/routes/route-provider-update.tsx 0 5 0.0%
src/features/workspace/components/workspace-download-button.tsx 3 14 21.43%
src/features/workspace/components/workspace-upload-button.tsx 3 16 18.75%
Files with Coverage Reduction New Missed Lines %
src/features/providers/hooks/use-confirm-delete-provider.tsx 1 0.0%
src/features/dashboard-messages/components/conversation-secrets-detected.tsx 2 0.0%
Totals Coverage Status
Change from base Build 13896570679: -0.2%
Covered Lines: 911
Relevant Lines: 1311

💛 - Coveralls

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lukehinds
Copy link
Contributor

@davolokh can you help with reviewing

lukehinds and others added 3 commits March 17, 2025 09:10

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@@ -57,8 +57,12 @@ export function ConfirmProvider({ children }: { children: ReactNode }) {
<ConfirmContext.Provider value={{ confirm }}>
{children}

<DialogModalOverlay isDismissable={false} isOpen={isOpen}>
<DialogModal>
<DialogModalOverlay
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just UX enhancements that make deleting using the UI more ergonomic, it became apparent these were needed when creating/deleting repeatedly during manual testing.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@alex-mcgovern alex-mcgovern merged commit 6baf15c into main Mar 17, 2025
7 of 8 checks passed
@alex-mcgovern alex-mcgovern deleted the feat/shareable-workspaces branch March 17, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants