-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shareable workspaces pt. 2 #1233
Conversation
…get-full-workspace-config
migrations/versions/2025_03_06_1324-4b81c45b5da6_add_provider_endpoint_name_to_muxes.py
Outdated
Show resolved
Hide resolved
…get-full-workspace-config
…github.com:stacklok/codegate into endpoint-to-get-full-workspace-config
migrations/versions/2025_03_06_1130-769f09b6d992_add_provider_endpoint_fields_to_muxes.py
Outdated
Show resolved
Hide resolved
migrations/versions/2025_03_06_1130-769f09b6d992_add_provider_endpoint_fields_to_muxes.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main thing is the db schema changes
migrations/versions/2025_03_06_1130-769f09b6d992_add_provider_endpoint_fields_to_muxes.py
Outdated
Show resolved
Hide resolved
…acklok/codegate into endpoint-to-get-full-workspace-config
…acklok/codegate into endpoint-to-get-full-workspace-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm , do we need a db migration for the changes to db/models?
There were DB schema changes in a previous iteration, but we decided they were unnecessary, the only change to a DB model is this one: class ProviderModel(BaseModel):
provider_endpoint_id: str
+ provider_endpoint_type: str
provider_endpoint_name: Optional[str] = None
name: str Which is populated via a JOIN — it's not the cleanest, but "it works"™️ |
Second part of #1067 — this adds a new endpoint
GET /api/v1/workspaces/:workspace_name
that returns a full workspace config.With this we have the prerequisites for a upload/download flow on a per-workspace basis.
These changes are integrated into the frontend in this PR: stacklok/codegate-ui#379
provider_endpoint_name
andprovider_endpoint_type
to themuxes
tableMuxRule
model used by the API to includeprovider_type
andprovider_name
and removesprovider_id
MuxRuleWithProviderId
model used internally for transportingmux rules
they don't require knowledge of the provider ID
GET /api/v1/workspaces/:provider_id
was already in use for listing providers in use by a workspace, but after speaking with @JAORMX we decided to move this elsewhere. You can achieve the same thing withGET /api/v1/workspaces?provider_name={ID}
now insteaddealt with in a separate PR