[Update] Make vue/prop-name-casing fixable
#402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Update] Make `vue/max-attributes-per-line` fixable * [fix] bug and style * [fix] Switch indent calculation method with node and attribute * [fix] don't handle indentation * [add] autofix test max-attributes-per-line.js
* [Update] Make `vue/order-in-components` fixable This Commit makes `vue/order-in-components` fixable. In case of `The "A" property should be above the "B" property` error, autofix will move A before B * [fix] fail test at [email protected] * [fix] If there is a possibility of a side effect, don't autofix * [fix] failed test at node v4 * [update] use Traverser * [fix] failed test [email protected] * [fix] I used `output: null` to specify "not fix"
mysticatea
reviewed
Feb 23, 2018
lib/rules/prop-name-casing.js
Outdated
| }, | ||
| fix: canFixPropertyName(item) ? fixer => { | ||
| return item.key.type === 'Literal' | ||
| ? fixer.replaceText(item.key, item.key.raw.replace(item.key.value, convertedName)) |
There was a problem hiding this comment.
If the original name is "🍻", what does it happen?
There was a problem hiding this comment.
Why!? It became "" !!!
Emoji is difficult...
|
Thanks for review! |
michalsnik
reviewed
Mar 21, 2018
| output: null, | ||
| parserOptions, | ||
| errors: [{ | ||
| // bug ? |
There was a problem hiding this comment.
I guess so, it shouldn't throw error in this case I think.
There was a problem hiding this comment.
But we can deal with it in separate task.
There was a problem hiding this comment.
Thank you for your view
I wrote an issue #442
michalsnik
approved these changes
Mar 21, 2018
This was referenced Mar 22, 2018
|
Make prop-name-casing fixable is very dangerous, because the fix code only fix the props name and leave the reference code same. I think the fix should leave to manual, we just show the alert and do nothing else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
vue/prop-name-casingfixable.This implements autofix of rules proposed in #252